at should throw if the key is missing

Question

at should throw if the key is missing

mhagmajer opened this issue 4 years ago · 7 comments

ask {
    const marta = { firstName: 'Marta' }
    marta:at('firstName3')
}

returns null (empty) but an error was expected (playground with AskVM v. 1.2.0)

Answer 1 · 2020-07-17T14:23:15.000Z

@czerwinskilukasz1 what's your opinion about this?

Answer 2 · 2020-07-17T14:23:42.000Z

I'd really like not to have two empty values like in JavaScript

Answer 3 · 2020-07-17T20:41:53.000Z

I'm fine with throwing as soon as we have hasKey: #400

Answer 4 · 2020-08-10T18:54:31.000Z

hasKey is implemented, this is unblocked now.

Answer 5 · 2020-09-15T13:12:54.000Z

Place to fix that in code: https://github.com/xFAANG/askql/blob/master/src/askvm/resources/core/at.ts

Answer 6 · 2020-10-22T14:51:13.000Z

I have created a pull request (https://github.com/xFAANG/askql/pull/523/files) with a unit test for this case. I will appreciate if someone could verify if the test is correct 😄
Next, I will work on changing the implementation of at to work as expected by the test

Answer 7 · 2020-10-23T08:29:51.000Z

My pull request is ready for review 😃