filter seems broken

Question

filter seems broken

munix9 opened this issue a year ago · 6 comments

Describe the bug
The filter seems broken.

To Reproduce
Steps to reproduce the behavior:
For example, select Comets: the list remains empty.

Expected behavior
The list should reflect the selection.
I think the last version in which it worked was https://github.com/CelestiaProject/Celestia/tree/0d11f549c5480afbc84089e1328f9c167ef8952d

Desktop (please complete the following information):

OS: openSUSE Tumbleweed 20240111
Frontend: QT5/6
Version: 1.7.0

Additional context
Development snapshot, commit dc6c66c.

Built for 64 bit CPU
Using GNU GCC 13.2.1 20231130 [revision 741743c028dc00f27b9c8b1d5211c1f602f2fddd]
Built against Qt library: 5.15.12
NAIF kernels are supported
AVIF images are supported
Runtime Qt version: 5.15.12

Built for 64 bit CPU
Using GNU GCC 13.2.1 20231130 [revision 741743c028dc00f27b9c8b1d5211c1f602f2fddd]
Built against Qt library: 6.6.1
NAIF kernels are supported
AVIF images are supported
Runtime Qt version: 6.6.1

Answer 1 · 2024-01-14T12:49:14.000Z

~~I think this is because the filter is operating on the stars as well, e.g. "Planets and moons" does not work with Sol (child of the Solar System Barycenter) but does work in, say, 51 Peg.~~

Did this ever work? The addTreeItemChildrenFiltered method on the Qt solar system ignores orbiting stars entirely.

Answer 2 · 2024-01-14T13:15:18.000Z

~~I think this is because the filter is operating on the stars as well, e.g. "Planets and moons" does not work with Sol (child of the Solar System Barycenter) but does work in, say, 51 Peg.~~

Did this ever work? The addTreeItemChildrenFiltered method on the Qt solar system ignores orbiting stars entirely.

I mean yes, that was the case in an older AppImage version (0d11f54).
Maybe I can find it again or rebuild it locally for testing.

Answer 3 · 2024-01-14T13:20:38.000Z

Doesn't work for me in 0d11f54 either - only way I see it would work is if it is using a version of the data catalogues that define the Sun as an independent star (i.e. not orbiting the Solar System Barycenter)

Answer 4 · 2024-01-14T13:35:51.000Z

I have found an older AppImage version in which it works:
https://provo-mirror.opensuse.org/repositories/home%3A/munix9%3A/unstable/AppImage/

celestia-1.7.0~git20231110+eeffce5-lp154.1.1.Build1.1.glibc2.17-x86_64.AppImage

Versions used for the AppImage:

celestia 1.7.0~git20231110+eeffce5
celestia-data 1.7.0~git20231104+3a9eeb9

And a more up-to-date version:
https://mirror.aardsoft.fi/opensuse/repositories/home%3A/munix9%3A/unstable/AppImage/

celestia-1.7.0~git20240105+0d11f54-lp154.1.1.Build1.1.glibc2.17-x86_64.AppImage

Versions used for the AppImage:

celestia 1.7.0~git20240105+0d11f54
celestia-data 1.7.0~git20231225+eb10d0a

The versions on the mirrors can change in the meantime if updates are made there.

Answer 5 · 2024-01-22T16:20:12.000Z

Using openSUSE Leap 15.2 and Qt5 (no Qt 6), I made a series of compiles of git commits to test the solar system browser. The data files remained the same and are from the Celestia content repository 12-25-2023, with stars.dat and nearstars.stc unmodified. Several spacecraft are from the Celestia Forum.

The browser was tested in three checks and the resultant screens are as follows.

Planets and moons, showing several levels including barycenter:

Single item Comets:

Single item Spacecraft:

Union of Comets and Spacecraft:

Celestia information for one of the commits:

It works as I expect for all the commits tested. All commits performed identically.

date -- commit
10-12-2023 -- f019191
12-26-2023 -- c2ae9e6
01-09-2024 -- b3a1368
01-13-2024 -- dc6c66c
01-21-2024 -- 10d69c5

Answer 6 · 2024-01-22T21:36:18.000Z

I have downloaded the windows artifacts from the following commits. The data files are from the Celestia Content master version at 01-22-2024. The additional files are from the Celestia master version at 01-22-2024. I extracted the files from the commits into the data files and ran the Windows Qt6 version of Celestia.

Working is a response that matches the above screens for Leap 15.2 Qt5 version with the exception that asteroids were substituted for spacecraft. Failing is a response only showing the barycenter as described by munix9.

date -- commit -- result
12-26-2023 -- c2ae9e6 -- failed
01-09-2024 -- b3a1368 -- failed
01-13-2024 -- dc6c66c -- failed
01-14-2024 -- f210f99 -- worked
01-21-2024 -- 10d69c5 -- worked

I also checked the Proxima system for planets by going to Proxima and refreshing the Solar Browser. Proxima system does not list a barycenter. The Solar Browser successfully showed the planets when the filter Planets and Moons was active. This occurred for all of the Windows Qt6 versions.

There is another combination that I have tested. I used the data files from the Celestia Content master version 09-23-2023 and the additional files from the Celestia master version 10-20-2023. I only tested the Windows Qt6 version from 12-26-2023 commit c2ae9e6. This combination worked - while the more recent data files failed. It appears that there is a link between the data files and Celestia code for Qt6.

But the good news is the most recent versions are working together. @munix9 should try to update the appimage to the most recent Celestia codebase and retry the error issue.