CelestiaProject/Celestia

Incorrect texturing for add-ons

levinli303 opened this issue · 1 comments

levinli303 commented

Describe the bug
Reported by mobile user, reproducible on desktop. See screenshots

To Reproduce
Steps to reproduce the behavior:

  1. Download Earth's Auroras add-on
  2. Go to Earth
  3. See error

Expected behavior

Screenshot 2024-01-14 at 23 43 50

Screenshots

Screenshot 2024-01-14 at 23 42 33

Additional context

The bad commit is 3d5ce7b#diff-7139070d8ab8a118bba0171ff5da4b90b7fa199c9d6d94e99c72d426ae9848a1

@ajtribick

ajtribick commented

This comes down to the use of Mesh "" in the Auroral Oval - this is now detected as an invalid filename and thus the Mesh declaration gets ignored, leading to the object being created as a sphere that intersects the actual Earth leading to the patterns. Previously this declaration would be accepted, resulting in the geometry having an invalid resource and thus not being rendered.

One fix is to remove the Mesh declaration, decrease the radius of Auroral Oval and increase the cloud height. This also has the bonus effect of not logging an error when it fails to load the nonexistent mesh.