Custom screen language statements changed their implementation
CensoredUsername opened this issue · 6 comments
Now they appear as a SLCustomUse node.
Wow.They're four years in and AFAIK never appeared anywhere. At least as a error src. Are they never used or slipped simply somehow through the decompiler?
If i get this from the Ren'Py implementation right, its similar to SLUse and could be used as template. Argumentinfo and ID is gone, but the args are in another way present and we gain a positional property?
There's not much reason to use it really. You only need them if you're doing something special in a screen that's still reasonable enough to do in a screen, yet not simple enough to just be a displayable.
No reason to work on that until there's a test case.
Applicable to both 7.5 and 8.0.
I add this small cosmetic/clean code issue here, because its related to print_use method in SL2:
Do we need the second arginfo call there? IMHO there should be just the "args" var from the first call passed in. Or do i make another mistake?
Nah you're correct. Seems like the first call is just unnecessary. Minor perf fix.