CenterForOpenScience/modular-file-renderer

MFR loading spinner lower resolution than other OSF spinners

NatashaRichter opened this issue · 4 comments

I reported this on the 0.46 trello board.

Steps

  1. Log into osf.io.
  2. Navigate to one of your projects.
  3. Click on a file to render it on the file detail page.
  4. Notice the spinner in the file tree and the spinner in the renderer as the page is loading.

Expected behavior

I expect the spinners to be the same resolution.

Actual behavior

The spinner in the MFR is lower resolution than other OSF spinners, including the one on the same page in the file tree on the left.

Screenshots

File tree spinner

files_grid_high_resolution_spinner

MFR spinner

mfr_low_resolution_spinner

The OSF's spinner should be the same file as the MFR's spinner, it looks like the latter is just being resized to fit a larger container. Replacing it with a higher res version should fix this.

@NatashaRichter -- should this be transferred to OSF issues?

MFR delivers the spinner file when it's rendering, so the issue belongs here, but it might receive more attention there. That being said, I can fix it in about 30 seconds if the above is the desired solution. A likely side effect would be that the spinner could be slightly larger, unless we're giving it an exact size.

@lbanner @mfraezz Whatever you both think is best. Caner had recommended I put it up here, but I can move it. All the OSF spinners are the same size now, except for this MFR spinner, which is larger than the others. If possible, we'd want it to be the exact size as the other spinners.