ChainSafe/chainbridge-core

Fix e2e tests

MakMuftic opened this issue · 0 comments

Our e2e tests were silently failing on CI.

Expected Behavior

On each new PR our e2e tests should run and provide feedback if new code is passing e2e tests.

Current Behavior

Currently even though inside Github UI it seems e2e tests are passing, if you inspect details of github actions you can see that e2e tests are failing. This error is omitted because inside CI configuration continue-on-error is set to true.

- name: Run tests
  run: make e2e-test
  continue-on-error: true

Needed changes

Change github action configuration and fix all aggregated errors:

  • Change address for contracts in test configuration
  • Fix erc20 constructor not connected to contract pointer
  • Fix erc721 deposit data generation
  • Fix wrong erc721 resource generation in tests
  • Fix simulate bug (related to a bug in go-ethereum when calling contract with 0x00..)
  • Change timeout when running e2e tests (default is 10 min, and it takes more when running them on CI)

Acceptance Criteria

  • e2e tests passing on CI