ChainSafe/chainbridge-solidity

Modifier onlyAdmin missing in Bridge.sol: add / removeRelayer

peak3d opened this issue 3 years ago · 1 comments

peak3d commented 3 years ago

Modifier onlyAdmin missing

chainbridge-solidity/contracts/Bridge.sol

Line 186 in ce60431

function adminAddRelayer(address relayerAddress) external {

Expected Behavior

Adding / removing relayer should be only allowed to admins

Current Behavior

Everyone is allowed to

Possible Solution

Add onlyAdmin modifier

Versions

main branch

P1sar commented 3 years ago

Admin role checked in the granRole function, it is mentioned in functions comment
https://github.com/ChainSafe/chainbridge-solidity/blob/master/contracts/Bridge.sol#L181