ChainSafe/mina-rs

[M1] Add missing variant and data structure in external transition

Closed this issue · 4 comments

sudo-shashank commented
  • Missing variants of TransactionStatus` --> Sample Block
  • Missing variants of CoinBase: Two
  • Missing variants of UserCommand: SnappCommand
  • Missing variants of SignedCommandPayloadBody: Create_new_token Create_token_account Mint_tokens
  • Add Tests
creativcoder commented

Tests blocked on: retrieving the relevant blocks for the missing variant.

sudo-shashank commented

image

https://chainsafeio.slack.com/archives/C02QZBXLCLD/p1652238321799669

So we don't need to add support for:

  • UserCommand: SnappCommand
  • SignedCommandPayloadBody: Create_new_token Create_token_account Mint_tokens
creativcoder commented

But I believe they might be needed for backward compatibility (for nodes running version of mina prior to hardfork)

sudo-shashank commented

But I believe they might be needed for backward compatibility (for nodes running version of mina prior to hardfork)

@matthew confirmed that these specific variants which he mentioned are unused and will not appear in any valid block