Modification of agent version for Lodestar
philknows opened this issue · 2 comments
Background
Details
Reference: ChainSafe/lodestar#4465
Lodestar is looking to modify the agent version gossiped from the default libp2p string js-libp2p/0.36.2 to lodestar/version. We are requesting an update to your client on how you identify Lodestar nodes for better tracking and referencing of Lodestar peers on the network for debug purposes. We will not implement until it has been completed between all the various clients on the network.
Acceptance criteria
Update crawler with how it identifies Lodestar on the network. Should detect Lodestar under lodestar/version.
From my understanding, no code change is required for how the crawler parses the UserAgent. This line splits the UserAgent into it's parts based off of /, so if Lodestar's UserAgent is Lodestar/0.41.0, we'd be storing the Peer with userAgent.Name = Lodestar and userAgent.version = 0.41.0
From my understanding, no code change is required for how the crawler parses the
UserAgent. This line splits theUserAgentinto it's parts based off of/, so if Lodestar'sUserAgentisLodestar/0.41.0, we'd be storing the Peer withuserAgent.Name = LodestaranduserAgent.version = 0.41.0
Right. Nothing required. I already tested this and Lodestar client was being parsed successfully.