ChanceSD/PvPManager

MMOitems conflict

Closed this issue · 3 comments

ferxsy commented

Describe the bug
When using MMOItems, when dealing dmg, or using a ability, every hits summons PVP Blood.
When using MMOitems abilities, they conflict with some and they are being false detected or something, they dont work.

To Reproduce
Steps to reproduce the behavior:

  1. just use a ability with default config lol
    Expected behavior
    Nothing, PM shouldnt interfer

Plugin and Server version
1.19.3, PM 3.10.9

ChanceSD commented

If the damage is against a player it seems fine to me that the blood effect is showing up.
About the second sentence, not sure what exactly doesn't work. The abilities from MMOItems or the PvP protection?

Let me just add that plugins (in this case MMOItems) should always check if other plugins are cancelling the damage event before applying their own damage/skills/spells/etc. I have never used that plugin though so it might be something I need to correct.

ChanceSD commented

You will have to give me an example of an item with those issues so I can reproduce it.
I didn't know anything about mmoitems but I gave it a try, I created a musket and tried some abilities and it worked just fine with pvpmanager.

ChanceSD commented

I'm closing this, will reopen if there's more details