ChaosMarc/PlugY

when you open 2 plugys, then create 2 characters and link by local net, plugy will crash

Closed this issue · 7 comments

by the way, I hope plugy runs without installing visual c++ 2015 redistributable.
You can statically compile this app.

I think this is caused by the shared stash. If you disable the feature completely (ActiveSharedStash=0) you should be able to play with multiple chars on your local network. Could you please check if this workaround "fixes" the problem for you? A correct fix for this would require to rewrite the way the shared stash is handled completely, which I'm not able to.

Actually I'm happy that I got it to compile at all :D It's been ages since I meddled with C++ / Visual Studio. Can you tell if it is compiled statically at the moment?

@ChaosMarc
about crash problem, I will try it as you said.
about static link, you can watch this website:
https://helloacm.com/how-to-static-link-vc-runtime-in-visual-c/

Thank you for the link. I will look into it

I have a suggestion:
when you play with multiple chars on your local network, the sharedstash button is disabled automatically and gives some message "this button is disabled because you play the game on local network", and the default value of ActiveSharedStash is 1.
this doesn't need to edit more code.
how do you think?

Sounds easier to implement for sure. As I'm no c++ developer this is something that would take me much longer than a few minutes.
I just tested it again. You need to disable the whole multi-page-feature as well (ActiveMultiPageStash=0). Otherwise you will get a crash after a few minutes or when exiting the game

@ChaosMarc now it cannot reassign skill point. The haxifix brach runs well.😁

@lishaoxia1985 I can use the skill unassign button regardless of the settings for ActiveSharedStash and ActiveMultiPageStash. Did you do something else? If this is a general problem for you it would be better to open a new issue. What version are you playing (or mod).