Log spamming on client 1.09d
Opened this issue · 1 comments
I had an issue with the last PlugY version 14.03. When opening the stash I receive the following message on my log 20.000 times:
16:34:29.313 ----- JONM NOTE: Would have crashed, see code at ITEMSDataGetPage. From FILE: C:\Src\Diablo2\Source\D2Common\ITEMS\Items.cpp LINE: 1163
It doesn't matter if the stash is empty or with items, tested with the previous official version 11.02 and the error didn't occur there, thanks for any fix...
It's caused by stash tab auto rename function. You can turn it off in .ini file with AutoRenameStashPage=0.
It's not working anyway, not for 1.09d at least. Items are not getting through D2GetRealItem before D2ItemGetPage, D2GetRealItem returns -1 for every item and actual logic is never executed. If you do the wrapping game will crash since SgptDataTables are seem not to be mapped for 1.09d and below. It seem to crash for misc items too, not sure why though.
Also there are other places where D2GetRealItem is not used for D2ItemGetPage (like in changeToSelectedStash_10. maybe in those assembly functions too?).