Chordian/deepsid

Clicking a SID row doesn't mark it properly on mobile devices

Chordian opened this issue · 2 comments

This is not an issue on desktop computer as they use a custom scrollbar plugin that marks the row correctly. However, mobile devices use native scrolling instead of this plugin.

It's also possible it only happens in playlists.

The phenomenon can be observed at certain rows in e.g. Luca's Favorites, and only when touching rows directly. Using the SKIP buttons seem to mark the rows correctly.

I first thought it was tied to duplicate versions of the same SID tune in a playlist (each with different sub tunes) but it turns out that the problem also occurs in other places where the SID tunes are unique.

Apparently this is only a problem when using the WebSid emulator. With Hermit's emulator the rows are marking themselves correctly.

I also tried letting a marked (problematic) SID row time out and choose the next SID tune row. This worked correctly with the WebSid emulator.

I moved two lines (for clearing/marking SID rows) up to be run before an asynchronous SID.load() function instead of after it. It seemed to fix this bug.