ChunhuanLin/deform_conv_pytorch

A problem about dilation and stride settings

Closed this issue · 1 comments

rxqy commented

Hi, great job. But I have some problems regarding dilation and stride settings.
If I want to add dilation into your deformable conv, is it right that I only need to change the settings in nn.Conv2D in conv_kernel and conv_offset?

Actually the problem is about your stride settings, I do not understand why you set stride to kernel size.
So I'm afraid that adding dilation straight-forwardly would cause problems.
I saw someone else discussing this issue here in #9 , but I donot really get your point : ((

rxqy commented

ehhhhh guess not?
Tried in mxnet, give different outputs.
There might be several lines of code you may want to change.
For example, how you generate p_n, offsets etc