CindyJS/website

Avoid !important rules

Opened this issue · 1 comments

gagern commented

Commit 33c1a76 added some !important rules to the CSS, but I don't think they should be neccessary and I think that having them will greatly reduce maintainability of the styling. Can we just drop them, or is there a particular reason we need them?

gagern commented

Apparently these rules mainly aim at making the examples from the source tree more visually appealing. I'd say we should do one of the following:

  1. restructure the examples in the repository to avoid that inline styling in the first place
  2. rewrite these examples on the fly while creating the website
  3. restrict these !important CSS rules to a file included with just these examples
  4. Restrict these rules to a selector only affecting these

That way cleaner parts of the layout will remain unaffected.