CiscoDevNet/ansible-meraki

meraki_webhook_payload_template - Problems with deletion?

kbreit opened this issue · 11 comments

@joshuajcoronado - I am having some problems with this module. I keep getting errors saying the template name is already created in the organization. However, the API refers to networks. The integration tests aren't self-contained either:

TASK [meraki_webhook_payload_template : Create webhook payload template] *******
fatal: [localhost]: FAILED! => {"changed": false, "msg": "HTTP error 400 - https://api.meraki.com/api/v1/networks/N_624874448297698169/webhooks/payloadTemplates - Name validation failed. A webhook payload template with this name already exists for this organization", "response": "OK (unknown bytes)", "status": 400}

I'd expect this to succeed.

alright, i'll plan to take a look at this

I may be going about it wrong. I just am confused since it seems to be taking different scopes into account when it comes to what it's searching for. Sometimes it's network (makes sense) and sometimes its organization.

@kbreit sorry, been on holiday PTO and what not, this week, and next will also be a bit short, so does this not need more 👁️ ?

I was thinking about extending the webhook module to intake payload templates, but i see that you're working on it, do you need me to pick it up?

Go ahead and pick it up. Thank you for asking!

@kbreit think we can get a new release so i can roll these changes out in my org?

@kbreit think we can get a new release so i can roll these changes out in my org?

I will get a release soon. I've been under the weather so haven't been on the computer.

@kbreit aw man, hope you feel better soon friend

@joshuajcoronado I just pushed 2.14.0. I think the webhook code could use some more tests and IIRC there's a problem or two with it, but we can address that in 2.14.1.