CiscoDevNet/ansible-meraki

Issue with the ansible-lint

y0rune opened this issue · 2 comments

y0rune commented

I found out that when I added the new commit into a specific branch the workflow check diff from that commit into a master latest branch.
For example:
When I added the new commit into a #409 It chacked a lot of files:
Link to action: https://github.com/CiscoDevNet/ansible-meraki/actions/runs/3976255493/jobs/6816623260
image

y0rune commented

That issue is still occurred due to fetch.
Resolved in #430.

Source of that fix:
actions/checkout#552 (comment)

EDIT: Fetching to a common ancestor may fail when you have commits belonging to the base branch in local history which have not been merged into the PR branch. This problem occurs with the default ref (the generated test merge-commit of the PR branch into the base branch) with a fetch-depth of 2 or more.

When I tested a new PR it worked (https://github.com/y0rune/ansible-meraki/actions/runs/3977154163/jobs/6818062752)

y0rune commented

Still that error occurred. (https://github.com/CiscoDevNet/ansible-meraki/actions/runs/3981709537/jobs/6825621898)
image

I think we cannot do it due to specific of that plug. I did not know if we can enable to do it (@kbreit)