Boolean parameter not converted correctly to PUSHT PUSHF opcodes

Question

Boolean parameter not converted correctly to PUSHT PUSHF opcodes

mfbz opened this issue 9 months ago · 2 comments

mfbz commented 9 months ago

Wallet version or commit SHA:
2.20.3

Environment:
any

Prerequisites:
any

Reproduction steps:

Start Neon Wallet
Invoke a contract with a boolean parameter

Description of the issue
When using a boolean parameter the script created for an invocation still uses the old Op Codes PUSH0 PUSH1 while it MUST use the new Op Codes PUSHF PUSHT otherwise after the latest neo-cli 3.6.0 update, contracts that rely on boolean parameters in events break and can't be called.

Here you can see the commit on the neonjs library where the new opcodes were added:
CityOfZion/neon-js@945363f

The solution would be to update the neonjs library to the latest version so that the createScript function correctly builds the script with the new Op Codes.