CiviWiki/OpenCiviWiki

add django-browser-reload

brylie opened this issue · 15 comments

Task

Hello, would be willing to work on this issue

Thanks, @Walexero 😀

okay, i guess i would get my hands off this then

@Walexero, sorry for the confusion. I seem to have forgotten to assign you to the issue when you claimed it.

@Mohammed-Saif0 , thank you for working on the issue in pull-request #1366. However, we will give @Walexero the opportunity to work on this issue since they claimed it four days ago.

Sorry again for the confusion.

okay thanks, would start working on it, i have another issue opened, have completed one of the tasks remains the second, please respond on the issue page

Hello is this issue still open? if it's so i'd like to give it a try

Hi @daaavo. @Walexero is still assigned to this issue but may like some help if you ask them.

Hello, @brylie. Is this issue still open?

Yes.

Hello @brylie. I don't know why my changes for this issue are failing the django-upgrade test. Here, is the response when trying to commit my changes.
`django-upgrade...........................................................Failed

  • hook id: django-upgrade
  • exit code: 1

Rewriting project/core/urls.py
`

It should have automatically fixed the code issues. Just stage the changes to urls.py and commit. The plugin makes sure we write code that uses the latest Django features and idioms.

Hello, @brylie. I have another error when trying to commit the changes...This is what I get after I stage the changes to urls.py
browerr

This is my log file
pre-commit.log

The error in the log file seems to be the following:

raise RuntimeError("The Poetry configuration is invalid:\n" + message)
RuntimeError: The Poetry configuration is invalid:
- [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

Try again on a fresh branch, from the latest develop. Then only run poetry add ... and the package name.

Hey @brylie. I actually managed to solve the issue. It's because of a new release of the v1.5.0 of poetry-core. I had to upgrade the isort core to v5.12.0.
Here is the commit ea81bab