CRC failed
mmitkevich opened this issue · 4 comments
with latest clickhouse-client-cpp release and clickhouse-server 23.x I get CRC error when using LZ4 compression in client.
I digged into CRC and server's ipml
https://github.com/ClickHouse/ClickHouse/blob/17f37541935bce25e2b200f061baafa4dadb338e/contrib/cityhash102/src/city.cc#L344
looks just like client's impl
https://github.com/ClickHouse/clickhouse-cpp/blob/master/contrib/cityhash/cityhash/city.cc#L339
but it does not work anymore. Probably it's worth to use the server's code here?
here is my server problem desc
ClickHouse/ClickHouse#53932
Hi @mmitkevich thank you for reporting!
Yes, we sure want to be compatible with ClickHouse's server implementation.
Could you please create a PR with the proposed changes?
Hi @mmitkevich could you please provide more info on that? I tested against 23.8 and wasn't able to reproduce the issue.
Do you have any sample code that reproduces that?
Hi, @mmitkevich! Have you by any chance used cityhash 1.1 which comes as an OS package? IIRC some versions might be incompatible...
After ensuring my program is linked against bundled cityhash it looks like the problem has gone