ClickHouse/clickhouse-java

Error message is too verbose

chernser opened this issue · 2 comments

chernser commented

Describe the bug

There are several problems:

  • Exception message is too verbose.
    • Client is adding server information what can be sensitive information (for service providers)
  • Server message is appended with unrelated to the error information.
    image

Expected behaviour

  • ClickHouseException message should contain only error message. No context information like server should present
Paultagoras commented

Is that considered sensitive information? In much the same way a stack trace can help, I think outputing the environment can help diagnose misconfigurstion - don't want to share passwords though, of course...

chernser commented

@Paultagoras it is fine to have it in logs. Exception messages should be very straightforward and only about error.
Exception may have some context saved within itself and it may be accessible by application for the debugging.