ClickHouse/clickhouse-js

BaseQueryParams.session_id is not used

Holi0317 opened this issue · 1 comments

Describe the bug

BaseQueryParams got an undocumented session_id that feels like it should override the session_id passed into createClient. But actually that field is never used and session_id is always using this.sessionId

session_id: this.sessionId,

Steps to reproduce

  1. Try to override session_id via BaseQueryParams

Expected behaviour

The session_id should be overridden

Fixed in 1.1.0. Also, session id override will be mentioned in the docs after ClickHouse/clickhouse-docs#2381 is merged.