ClickHouse/clickhouse-js

BaseClickHouseClientConfigOptions interface should define keep_alive. idle_socket_ttl

brian-mann opened this issue · 1 comments

brian-mann commented

Expected behaviour

Per the official docs there is a keep_alive.idle_socket_ttl that's should be configurable.

https://clickhouse.com/docs/en/integrations/language-clients/javascript#keep-alive-configuration-nodejs-only

However the types only have the keep_alive.enabled property, it's missing idle_socket_ttl per this file:

https://github.com/ClickHouse/clickhouse-js/blob/main/packages/client-common/src/config.ts#L75-L79

slvrtrn commented

This is a Node.js-specific setting; the correct interface is here, which extends BaseClickHouseClientConfigOptions.

It is properly recognized by the IDE, e.g.:

image