ClickHouse/metabase-clickhouse-driver

IPv4 field starts with dash

phuntik opened this issue · 4 comments

Describe the bug

IPv4 type field visualization starts with dash.
2023-09-08T16:59:55

Is it expected? Why does it work like this? I didn't find any specifications ordering to show ip addr with dash.
Appreciate your reply.

Steps to reproduce

select toIPv4('127.0.0.1')

Expected behaviour

127.0.0.1

Configuration

Environment

  • metabase-clickhouse-driver version:
    seems like 1.1.7
    how can check this, btw?
  • metabase-clickhouse-driver configuration:
    default
  • Metabase version:
    v0.46.6
  • OS:
    CentOS 7

ClickHouse server

  • ClickHouse Server version:
    22.8.14 revision 54460

Also might be worth mentioning.
I'm using mysql to store Metabase config. In metabase.metabase_field table there are multiple fields related to data types. I've tried to manually update some of them ipv4->string to mimic string behavior, but it didn't work either, showing dash anyways.

update metabase_field set base_type='type/Text' where id=53365;
update metabase_field set effective_type='type/Text' where id=53365;
update metabase_field set database_type='String' where id=53365;

IIRC, that's how Java serializes these types by default (see InetAddress.toString).
But it's easy enough to fix so it is less annoying 👍

Thanks a lot, appreciate!