Doesn't account for area codes (ie +44 == 0)
Closed this issue · 10 comments
When using the webapp or chrome extension, it counts the numbers +441234567890 and 01234567890 as different numbers, so the messages to and from the two numbers ( which are the same ) appear in different threads. also, it only recieves the contact names for the one you have stored in your contacts. so say 01234567890 was in your contacts as steve, messages from +441234567890 would not come up as being from steve.
I'll try and fork and submit a patch.
Oh this should be relatively easy to fix. contacts.numbersOnly just needs to be modified to trim off any prefixed 0's before doing the fuzzy matching. I'll make that change tomorrow morning. Sleep time now!
Okay cool cheers :)
Whoops, didn't mean to close it, wrong button
This should be fixed. Can you refresh/reload the page and confirm?
I think the Chrome extension may cache the scripts and such for 1 day before refreshing, so that may not get fixed immediately. You can also clear the browser cache to force it of course.
They are now shown as one conversation, but the numbers are not linked to the accounts. This is probably because it is looking in the contacts for the +44 number but they are stored as an 0 number.
by that I mean it is showing the number, not the contact name
scratch that, I just had to sync contacts again
yeah that's fixed now