Cloud-Automation/node-modbus

Request address is returning unitId

Opened this issue · 1 comments

miqmago commented

node-modbus/src/tcp-request.ts

Line 31 in af7ddd3

return this.unitId 

  get address () {
    return this.unitId
  }

  get slaveId () {
    return this.unitId
  }

I'm not sure if this is the correct value, shouldn't it return return this._body._start || this._body._address?
In case of slaveId I'm not sure of the value that should be returned...

stefanpoeter commented

Yes, that is probably a bug :-)