Code-Bullet/Enigma-Simulator

I don't know how to request changes so here goes. Basically, there is a line of code that changes one of the rotors when you type

jso8910 opened this issue · 3 comments

Ok, here it is:

    if (currentNo == inputNo) {
      println(inputNo, rotor1.position, rotor2.position, rotor3.position);
    }
    // This line below
    moveRotors();

    return letterOrderLowerCase.charAt(currentNo);
  }

This is line 57 in the Enigma class. For anyone wondering, the solution is to remove it (though I recommend commenting it out), but I would appreciate if someone removed it from the master branch. Anyways, that is the issue with the solution.

The engima did advance the right most rotor with each keypress, and after a certain amount of presses it would advance the next rotor by one and so one. So the rotors being advanced is correct

The engima did advance the right most rotor with each keypress, and after a certain amount of presses it would advance the next rotor by one and so one. So the rotors being advanced is correct

I did not know that! I had some notion that you wrote down the message, and just put it back in and the correct ones will light up. Do you also (somehow) write the starting position of the right one?

@jso8910 Can you close this out since it's not an issue?