✨ Support fish shell
sgruby opened this issue · 6 comments
Description
Currently it appears that only bash and zsh are supported shells. My default shell is fish and I can't use the terminal pane because of it. I modified the code to add fish to my local copy (not with the integration, just to allow it as an option) and it appears to work fine.
Alternatives Considered
No response
Additional Context
No response
Screenshots
No response
The big thing to support here is the terminal integration. See this code here. We'll likely need a new integration script, and to add a case to this enum and the Shell enum.
@thecoolwinter don't know much about Bundle.main here, could you explain? I'm not able to call the fish shell throws error
@thecoolwinter don't know much about Bundle.main here, could you explain? I'm not able to call the fish shell throws error
You can drag the file into the same folder as the other shell integration files in Xcode and Xcode will know to copy it into the bundle.
It's the ShellIntegration folder.
@thecoolwinter don't know much about Bundle.main here, could you explain? I'm not able to call the fish shell throws error
https://github.com/CodeEditApp/CodeEdit/pull/1908/files#diff-6aaec9c4526c8226b2f628df417695d65f9d22091b06526cd7d71cf1d35f4896R168-R173You can drag the file into the same folder as the other shell integration files in Xcode and Xcode will know to copy it into the bundle.
I meant can we know where we can find it? Like other shell files? Is it in Info.plist?
Sorry my bad I found out the folder that you meant, I was dumb... was thinking how you pointing me to the enum