CodeEditApp/CodeEdit

✨ Add missing theme tokens

Opened this issue · 0 comments

Description

We currently have "Types" and "Variables" theme tokens. We should replace these two with "Types Declarations", "Type Names", "Variable Declarations", "Variable Names". There are also several more that we might add...

  • classNames
  • typeDeclarations
  • typeNames
  • variableDeclarations
  • variableNames
  • functionDeclarations
  • functionNames
  • propertyNames
  • constants
  • parameterNames
  • moduleNames
  • namespaceNames
  • preprocessorMacros
  • enumMembers
  • annotations

If we added these, the complete token list would look like this...

  • text
  • background
  • insertionPoint
  • lineHighlight
  • selection
  • invisibles
  • keywords
  • classNames
  • types
  • typeDeclarations
  • typeNames
  • attributes
  • commands
  • values
  • constants
  • numbers
  • strings
  • characters
  • variableDeclarations
  • variableNames
  • propertyNames
  • parameterNames
  • functionDeclarations
  • functionNames
  • moduleNames
  • namespaceNames
  • enumMembers
  • preprocessorMacros
  • annotations
  • comments

Additional Context

In Xcode, class names, function names, type names, etc. are differentiated between “Project” and “Other”. This helps developers quickly see what’s part of their project vs. an external dependency, making it easier to navigate complex projects, identify ownership of code, and make refactoring decisions. Is this something we want to implement as well?

We also need to update all of our bundled themes to include these tokens.