CodeForBaltimore/Healthcare-Rollcall

User unable to unlink a contact from entity.

Closed this issue · 4 comments

stoopidJSON commented

User Story

As a Healthcare RollCall user
I want the functionality related to unlinking contacts to work
So that I can unlink contacts

Acceptance Criteria

  • When on the Facility CheckIn page, I can click on a contact
  • When on the Contact Information page, I can click on Unlink Contact
  • When I click on Unlink Contact and then ok on the pop-up, the contact is unlinked
  • PR merged to master

Notes

This was possible via the contact endpoint so it appears to be a front end issue.
curl -X POST "http://localhost:3000/contact/unlink/a8e6d471-e460-4378-9fa4-c22c323671c1" -H "accept: /" -H "token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VybmFtZSI6InRlc3QiLCJpYXQiOjE1ODA3NTM0MDUsImV4cCI6MTU4MDgzOTgwNX0.Q6W7Vo6By35yjZBeLKkk96s8LyqIE2G39AG1H3LRD9M" -H "Content-Type: application/json" -d "{"entities":[{"id":"39fc640e-6342-4aa2-b55f-4a901c923478"}]}"

While user tries to click on Unlink Contact Link, system displays below pop-up. Once user clicks on ok from pop-up, API return 404: Not Found. response and Contact is not unlinked.

image

blakenan-bellese commented

This seems to work (see this video for evidence). @revjtanton, Can you review and close if you agree?

joshglazer commented

@blakenan-bellese @revjtanton I'm also unable to reproduce this issue. But I did notice that you can't choose the first item in the dropdown without first selecting the second, and then selecting the first again. Maybe that's the issue?

Either way, I think it might be nicer to update the UI so that each facility is listed in a table format, with a trashcan/delete button next to each one. That way, you can see all of the linked facilities on the screen without having to open up a dropdown, and the usability bug I mentioned above would be solved too. If this is something you all are interested in, I can create a new issue and then build that out. Let me know.

blakenan-bellese commented

@joshglazer I like your suggestion on the UI enhancement. Make it happen! Thanks.

joshglazer commented

@blakenan-bellese Great! I'll close out this ticket and create a new one (and assign it to myself).