CodeRibbon/CodeRibbon-Theia

Phosphor subclass BoxPanel to support restoreLayout

robobenklein opened this issue · 2 comments

The Ribbon components want to derive BoxPanel instead of the DockPanel like TheiaDockPanel does, however the phosphor BoxPanel is not feature-complete to DockPanel.

new sub-implementation of ImprovedBoxPanel and ImprovedBoxLayout should be able to support the dock version of restore/save.

note to self: will want for IBL to check children for exported layout states (and fail nicely if they don't have them - like items in a patch might have scroll-position only for text?)

The primary ribbon looks to need it's own ILayoutConfig since it needs additional data like overview and focus, but I think for now IBL/IBP will handle the strip save/restore, since I don't think strips need any extra data on top of the BoxLayout?