CodeTanzania/emis-dashboard

Eslint fix for settings

kasongoyo opened this issue · 4 comments

@mkumbobeaty the changes from you that got merged to develop branch a while ago had eslint errors? Did you fix them and submit new request? If not then can you do so because this make develop branch dirty and other can't actual merge their changes. But how did those changes pass through travis @BenMaruchu

@kasongoyo what are the errors in eslint? can you take a screenshot cause Travis doesn't have show any error

screen shot 2018-11-21 at 15 00 12

@BenMaruchu I am getting that error after pulling from develop and run lint:fix

@kasongoyo I think you haven't install dependencies

@BenMaruchu That's correct. Thanks for prompt reply.