Comments from a review of week 1
NateWr opened this issue · 1 comments
From @LucyMac:
- I love that you quietly introduce the BEM notation!
- Week 1 - 3 - semantic tags: Should students be given a hint not to lose the class names when they replace the tags? Or it can just be a bonus for those that figure it out :p
- Week 1 - 5 - CSS selectors: The instructions say not to edit index.html but the CSS file is not linked in the index.html's head, and any changes to the CSS file provided do not display. I may be missing the trick here - though I guess that may mean someone else will get it wrong too :)
- Week 1 - 6 - CSS properties: I love this exercise!
- Week 1 - 7 - I was a bit confused by the numbers that have appeared at the top of the messages. I realise they are there for students to experiment with the box model, but as they don't have an obvious purpose within the messages thread, it raised the question of why they had been added - could easily be fixed by explaining what they represent / giving them a 'meaning' in the UI?
- Week 1 - 8 - Nice intro to git branches. I think it's fine but it could be made a little more challenging by letting students figure out how to create the 'green_links' branch? Rather than giving them the commands? Just a thought :)
I love that you quietly introduce the BEM notation!
Yes! We tried to teach this in week 3 in previous classes and it was never very successful. I thought I'd let them soak it up anyway.
Week 1 - 3 - semantic tags: Should students be given a hint not to lose the class names when they replace the tags? Or it can just be a bonus for those that figure it out :p
Good idea! 👍
Week 1 - 5 - CSS selectors: The instructions say not to edit index.html but the CSS file is not linked in the index.html's head, and any changes to the CSS file provided do not display. I may be missing the trick here - though I guess that may mean someone else will get it wrong too :)
D'oh! Good catch!
Week 1 - 7 - I was a bit confused by the numbers that have appeared at the top of the messages. I realise they are there for students to experiment with the box model, but as they don't have an obvious purpose within the messages thread, it raised the question of why they had been added - could easily be fixed by explaining what they represent / giving them a 'meaning' in the UI?
Good idea! Maybe we can use pagination to demonstrate this better.
Week 1 - 8 - Nice intro to git branches. I think it's fine but it could be made a little more challenging by letting students figure out how to create the 'green_links' branch? Rather than giving them the commands? Just a thought :)
Yeah, maybe I made it too easy! I am feeling guilty after last year, when I tried to teach them how to resolve merge conflicts in week 1. It was a disaster! They will get more branch practice in weeks 2 and 3, but I'll look at maybe making this exercise a bit more challenging.