CodecademyCommunity/codecademy-discord-bot

Discord partials are enabled without validation potentially causing unexpected behavior

Closed this issue · 0 comments

Describe the bug

Discord partial structures are enabled which can result in incomplete data. The partials do not seem to serve a purpose in the code and are only referenced in client.js where they are enabled and then logDeletedMessages where no action is taken if the msg is a partial.

Expected behavior

Removal of partials should not cause any new bugs and should remove risk of partials causing unexpected errrors.

To Reproduce

I am not aware of a way to reproduce a partial message with local bot. But the amount of different messages for the deployed bot means that having partials enabled adds risk of bugs.

Additional context

Discord.js v12 docs about partials: https://discord.js.org/#/docs/discord.js/v12/topics/partials
Discord.js guide about partials: https://discordjs.guide/popular-topics/partials.html#enabling-partials