Codeinwp/neve

Breadcrumb NavXT integration is broken

Closed this issue · 4 comments

piit79 commented

Description

Breadcrumb NavXT integration is not working properly. The rendering of Breadcrumb NavXT breadcrumbs was apparently removed in commit ee748ab (by mistake I assume).

Step-by-step reproduction instructions

  1. Install Breadcrumb NavXT
  2. Enable breadcrumbs in Breadcrumb NavXT
  3. Breadcrumbs are not rendered in Neve

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

selul commented

@piit79 thanks for reporting, we will look into it.

piit79 commented

Thanks! I thought I'd submit a PR - the fix itself is trivial (just reintroduce the code at the end of maybe_render_seo_breadcrumbs() that was removed by mistake), but the contrib guidelines call for adding a test and running all the tests etc. which of course is a good idea, but sadly too time consuming for me at the moment.

selul commented

Hi, sure, feel free to send one without and I will have a look.
Thanks!

  • 👍1
pirate-bot commented

🎉 This issue has been resolved in version 3.8.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀