Allow to provide FQDN for localhost redirect
ManojSN opened this issue · 4 comments
ManojSN commented
BrowserAuth currently is hardcoded to use http://localhost. Prefer to pass the request_uri_domain as a keyword arg, with default being http://localhost.
Colin-b commented
Do you mean that you have some kind of alias for localhost? The token needs to be received in some way, how would this work?
ManojSN commented
Hi Colin,
Thanks for responding, I was going to send you a PR.
The request is to allow the implementor to be able to provide a fqdn for local host.
http://localhost.somecompany.com
I just sent a PR for your initial comments
Manoj Nair
Thanks
Manoj
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Colin Bounouar ***@***.***>
Sent: Wednesday, October 26, 2022 12:25:28 PM
To: Colin-b/requests_auth ***@***.***>
Cc: ManojSN ***@***.***>; Author ***@***.***>
Subject: Re: [Colin-b/requests_auth] Allow domain name to be provided to authentication.BrowserAuth (Issue #74)
Do you mean that you have some kind of alias for localhost? The token needs to be received in some way, how would this work?
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACKSJAZD36LYD6HGWPBLWQTWFFLPRANCNFSM6AAAAAAROQ6MEU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
ManojSN commented
Hi Colin,
As for the SonarCode analysis, guessing only you can accept the risk with hardcoded http://
Manoj
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Manoj Nair ***@***.***>
Sent: Wednesday, October 26, 2022 1:33:09 PM
To: Colin-b/requests_auth ***@***.***>
Subject: Re: [Colin-b/requests_auth] Allow domain name to be provided to authentication.BrowserAuth (Issue #74)
Hi Colin,
Thanks for responding, I was going to send you a PR.
The request is to allow the implementor to be able to provide a fqdn for local host.
http://localhost.somecompany.com
I just sent a PR for your initial comments
Manoj Nair
Thanks
Manoj
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Colin Bounouar ***@***.***>
Sent: Wednesday, October 26, 2022 12:25:28 PM
To: Colin-b/requests_auth ***@***.***>
Cc: ManojSN ***@***.***>; Author ***@***.***>
Subject: Re: [Colin-b/requests_auth] Allow domain name to be provided to authentication.BrowserAuth (Issue #74)
Do you mean that you have some kind of alias for localhost? The token needs to be received in some way, how would this work?
—
Reply to this email directly, view it on GitHub<#74 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACKSJAZD36LYD6HGWPBLWQTWFFLPRANCNFSM6AAAAAAROQ6MEU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Colin-b commented
Version 8.0.0 is available on pypi and fixes this issue