Collabo93/SortGroup

Issue request and bug with new patch?

Opened this issue · 1 comments

Feature request would be to have an option to only have the addon load in an arena.

Issue is quite major as it causes unplayable FPS stuttering/lag.
It gets expedited when using the Party Frame resize addon in conjunction with sort group. Doing group content while leveling where people change levels or leave the group causes it to break.

Edit: After messing around I don't think sortgroup is at fault but it does definitely amplify the problem.

Curious if there has been any progress to maybe make the addon stop breaking on party leaving/resize/levelup?

Could just be a blizzard issue as well, but if there is a workaround I would be grateful.

Message: Interface/FrameXML/EditModeUtil.lua:27: attempt to perform arithmetic on local 'offsetX' (a nil value)
Time: Sat Jan 28 20:14:56 2023
Count: 6
Stack: Interface/FrameXML/EditModeUtil.lua:27: attempt to perform arithmetic on local 'offsetX' (a nil value)
[string "@Interface/FrameXML/EditModeUtil.lua"]:27: in function GetRightActionBarWidth' [string "@Interface/FrameXML/EditModeUtil.lua"]:53: in function GetRightContainerAnchor'
[string "@Interface/FrameXML/UIParent.lua"]:3157: in function UIParentManageFramePositions' [string "@Interface/FrameXML/UIParent.lua"]:2632: in function <Interface/FrameXML/UIParent.lua:2619> [string "=[C]"]: in function SetAttribute'
[string "@Interface/FrameXML/UIParent.lua"]:3179: in function UIParent_ManageFramePositions' [string "@Interface/FrameXML/EditModeManager.lua"]:614: in function UpdateRightActionBarPositions'
[string "@Interface/FrameXML/EditModeManager.lua"]:566: in function UpdateActionBarLayout' [string "@Interface/FrameXML/EditModeSystemTemplates.lua"]:743: in function UpdateGridLayout'
[string "@Interface/FrameXML/ActionButton.lua"]:348: in function <Interface/FrameXML/ActionButton.lua:337>
[string "=[C]"]: in function UpdateAction' [string "@Interface/FrameXML/ActionButton.lua"]:801: in function OnEvent'
[string "@Interface/FrameXML/ActionButton.lua"]:196: in function <Interface/FrameXML/ActionButton.lua:193>

Locals: self =

{
GetSettingMapFromSettings = defined @Interface/FrameXML/EditModeUtil.lua:58
IsRightAnchoredActionBar = defined @Interface/FrameXML/EditModeUtil.lua:3
GetRightContainerAnchor = defined @Interface/FrameXML/EditModeUtil.lua:52
IsBottomAnchoredActionBar = defined @Interface/FrameXML/EditModeUtil.lua:8
GetRightActionBarWidth = defined @Interface/FrameXML/EditModeUtil.lua:18
GetBottomActionBarHeight = defined @Interface/FrameXML/EditModeUtil.lua:33
}
offset = 50.000057
point = nil
relativeTo = nil
relativePoint = nil
offsetX = nil
offsetY = nil
(*temporary) = 95.000069
(*temporary) = 45.000011
(*temporary) = MultiBarLeft {
0 =
buttonPadding = 2
GetShowAllButtons = defined @Interface/FrameXML/ActionBar.lua:202
UpdateSystemSettingAlwaysShowButtons = defined @Interface/FrameXML/EditModeSystemTemplates.lua:860
UpdateMagnetismRegistration = defined @Interface/FrameXML/EditModeSystemTemplates.lua:594
GetSnapOffsets = defined @Interface/FrameXML/EditModeSystemTemplates.lua:479
UpdateFrameStrata = defined @Interface/FrameXML/ActionBar.lua:206
UpdateButtonArt = defined @Interface/FrameXML/EditModeSystemTemplates.lua:757
IsFrameAnchoredToMe = defined @Interface/FrameXML/EditModeSystemTemplates.lua:557
downKeys =
{
}
buttonTemplate = "MultiBar4ButtonTemplate"
ShowBase = defined =[C]:-1
IsShown = defined @Interface/FrameXML/ActionBar.lua:307
GetSelectionOffset = defined @Interface/FrameXML/EditModeSystemTemplates.lua:431
ResetToDefaultPosition = defined @Interface/FrameXML/EditModeSystemTemplates.lua:216
RefreshButtonArt = defined @Interface/FrameXML/EditModeSystemTemplates.lua:750
GetScaledSelectionSides = defined @Interface/FrameXML/EditModeSystemTemplates.lua:423
SelectSystem = defined @Interface/FrameXML/EditModeSystemTemplates.lua:622
buttonArtDirty = false
GetFrameMagneticEligibility = defined @Interface/FrameXML/EditModeSystemTemplates.lua:577
AddLayoutChildren = defined @Interface/SharedXML/LayoutFrame.lua:48
IsBelowFrame = defined @Interface/FrameXML/EditModeSystemTemplates.lua:390
UpdateSystemSettingIconSize = defined @Interface/FrameXML/EditModeSystemTemplates.lua:802
SetScaleBase = defined =[C]:-1
HasActiveChanges = defined @Interface/FrameXML/EditModeSystemTemplates.lua:312
GetScaledCenter = define

Basically taints can happen with any piece of code that modifies existing Blizzard code without using provided widget API.

This addon calls CompactUnitFrame_SetUnit which has side effects outside of widget APIs. So taints will almost always happen at some point.

As long as it's not causing the stutter, I think it's okay to ignore them.