New theme version 1.3 generates an Fatal error
vinoddalvi opened this issue · 5 comments
After activating new theme version 1.3 displays following fatal error
Fatal error: require_once(): Failed opening required 'inc/libraries/epsilon-framework/class-epsilon-autoloader.php' (include_path='.:/opt/lampp/lib/php') in /opt/lampp/htdocs/colorlib/wp-content/themes/activello/functions.php on line 316
@puikinsh @vinoddalvi - It appears that this error is actually being caused by GitHub's web interface being silly. Build or "Download master" don't take into account any of the sub-modules being referenced inside the repo (in this case, Epsilon Framework) while using the CLI is absolutely fine.
I'm going to be closing this issue as well as the associated pull request: #90 as there's no need to add the sub-module directly inside the theme's folders - not on github. Up until now, we've never built our releases using GitHub's internal tools, but rather relied on Grunt to do this as well as some other miscellaneous tasks.
Bottom line is this: never use GitHub's internal tools to generate a ZIP when you've got a git sub-module inside your project. The files available in this repo work absolutely fine, it's just the build process that was faulty.
P.S: Maybe we should add this in the theme's readme.txt file - opinions?
Adding info on readme would be fine but it will still increase the number of tickets here on Github as no one reads the readme but at least we'll have a reference.
Since most GitHub users are actually developers themselves, I'm thinking (read: hoping) they'll be looking at the readme.txt/.md when a regular download & install doesn't work. More so, we'll be adding a Travis CI & Grunt integration to generate a /builds folder that'll hold an actual ZIP build with the sub-module included.
@puikinsh - if none of the above seem feasible to you, just let me know and we'll just hard-code the epsilon-framework directly into the projects instead of adding them as sub-modules.
@giucu91 & @c0sm1n87 - please see this: #89 (comment)