Merge `conservation_rules` and `rule_priorities` attributes
Opened this issue · 5 comments
redeboer commented
grayson-helmholz commented
Aside from tests, Edge/NodeSettings
is mainly used in settings.create_interaction_settings(...)
but which is then heavily employed in the StateTransitionManager
. Should this be in its own branch?
redeboer commented
Should this be in its own branch?
Yes as far as possible it is better to keep refactorings isolated and small
redeboer commented
Some idea after discussions: we could write something like:
conservation_rules: dict[GraphElementRule, RulePriorities]
where RulePriorities
is Annotated
grayson-helmholz commented
Rewriting get_rules_by_priority()
with the new definitions of Edge|NodeSettings
causes an infinite-loop in tests/channels/test_y_to_d0_d0bar_pi0_pi0.py