CommunityToolkit/ColorCode-Universal

'csharp' name missing for aliases

michael-hawker opened this issue · 3 comments

michael-hawker commented

I think GitHub uses csharp as an identifier:

public class Test {
...
}

But it's not looked for here: https://github.com/WilliamABradley/ColorCode-Universal/blob/master/ColorCode.Core/Compilation/Languages/CSharp.cs#L117 (which I think is what's used for the matching?)

WilliamABradley commented

Those just contain the Alternate Aliases, the Language ID is csharp, which is checked against first.

If you look at the Xml Language, it checks xml first, and I added XAML and AXML to the list. Some languages have no Aliases, like I believe Fortran.

michael-hawker commented

Is that the LanguageId? As they have c# instead of csharp so we'd need the other as the alias still, eh?

WilliamABradley commented

Thats true, I'll fix that.