ConnorDY/OSRS-Environment-Exporter

OSRS-Environment-Exporter violates RuneLite license

Adam- opened this issue · 3 comments

Adam- commented

First off, this is a nice project and I appreciate the work you have put into it. I see that it uses both the renderer from RuneLite and also some of the cache tooling. While you are allowed to release this under GPL-3, you must also retain the existing BSD-2 license and also release it under that, it is not okay to de-license the code as you are doing. BSD-2 states that the license & header must be included in any redistribution of the work, with or without modification.

I see that some effort has gone into preserving the licenses on some of the files, particularly the shaders, which I appreciate. There are several other files missed. For example, SpirteLoader, which has 11 identical comments to RL, including this 3-line one:
image
which makes it obviously a modified work.

Most of your renderer seems to be modified RL code too, it even has a comment about the plugin from RL which obviously is no longer applicable to it
image

Note that these are just random samples, I think almost everything in cache was just RL with a java to kotlin converter run on it.

I ask that you reinstate the original license header to each file that is derived from a file in RuneLite.

Thanks,
Adam

Hi, apologies, it was not our intent to remove the license from any of the code present in here. The project had quite a rocky start involving code and contributors both going missing which has made a lot of the earlier code a lot less traceable via any sensible git history, and while we've done what we can to put things back together, evidently there are parts we have missed.
Once I'm back from work I will look into which files derive code from runelite and put the correct license notice onto each one.

What we have done so far is:

  • Split the Renderer class up into original code and code derived from RuneLite, and provide the appropriate license message on the derived code
  • Attach the RuneLite license to other classes which appear to have originated from RuneLite code
  • Add a license acknowledgement including full license text and link-back to runelite.net in the about dialog of the compiled program

With the above addressed, is there anything that still needs to be done at this point?

On another note, if there are any original works in this project which are not in a RuneLite-licensed file that you would like to include back in the RuneLite project, I would be happy to provide that code separately under a compatible license for parts which I have authored.

Adam- commented

That sounds good. Thank you for the effort.

If you find any bugs or improvements feel free to PR them back.