ConsenSysMesh/india-training

Homework 3 - uniformity in event parameter names

Closed this issue · 1 comments

In AbstractMultiSig.sol, the following 5 events are mentioned

event ReceivedContribution(address indexed _contributor, uint valueInWei);
event ProposalSubmitted(address indexed _beneficiary, uint _value);
event ProposalApproved(address indexed _approver, address indexed _beneficiary, uint _value);
event ProposalRejected(address indexed _approver, address indexed _beneficiary, uint _value);
event WithdrawPerformed(address indexed beneficiary, uint _value);

can we change the below two events to follow the same convention (I am writing unit test cases and came across this)

event ReceivedContribution(address indexed _contributor, uint _value); // value to _value
event WithdrawPerformed(address indexed _beneficiary, uint _value); //beneficiary to _beneficiary

As per the mid week Q&A with Daniel, Daniel has agreed to make the parameter names uniform.