Consensys/Tokens

Throw on failed transfer?

simondlr opened this issue · 4 comments

simondlr commented

Hey @skmgoldin. Seems like consensus is that we should throw when not having enough balance (vs return false).

https://github.com/ethereum/EIPs/pull/610/files

Never fully liked this. It's a trade-off in its own right, but if the community is moving to this, do we want to change to this?

skmgoldin commented

I think it's a great idea if by throw they mean revert. Those will be catchable errors in Metro. I think they must mean this, let me ask in the EIP.

  • 👍1
skmgoldin commented

I think they must mean revert because throw is actually deprecated in Solidity now.

simondlr commented

Yes, I assume it's revert as well.

skmgoldin commented

I'll work on a PR.