Consensys/corset

Unused Field `Column::shift` ?

Closed this issue · 1 comments

DavePearce commented

I believe the following field defined in column.rs is unused and could be safely removed:

pub struct Column {
    ...
    pub shift: i16,

I don't know what this field is supposed to do, but if it is deleted ... then corset still builds. Therefore, I propose to remove this field altogether.

@delehef Any thoughts on this?

delehef commented

Yes, it can be safely removed.

  • 👍1