Consensys/corset

Column names are truncated in `corset inspect` when filtering columns

Closed this issue · 2 comments

letypequividelespoubelles commented

How to reproduce:
Open a .lt trace with corset -inspect.
Filter columns (using f terminal command)
Results: some columns name are not full (the STACL_ITEM_VALUE_HIGH_#) in this case:
image

Note: column names are well displayed when no filter, so this is a low priority bug

DavePearce commented

Hey @letypequividelespoubelles A few quick questions:

  • What version of Corset are you using?
  • Is this behaviour new? As in, it was previously displaying properly and is now not?
letypequividelespoubelles commented
  1. last corset release v0.9.12
  2. no idea

Precision, it seems the issue is only when the longest column is declared as an array, and so the last character (its array index) is forgotten. If we filter with longer columns it appears back.
Maybe putting a +2 instead of +1 in

corset/src/inspect/mod.rs

Line 135 in d7b4ee5

let span = 0.max(self.h_shift)..(self.h_shift + CONTEXT).min(self.size) + 1;
would solve ?