Consensys/linea-tracer

Incorrect ordering of `R` and `S` in `TransactionSnapshot.Of`

Closed this issue · 2 comments

Currently, we have this in TransactionSnapshot.java (see here):

public record TransactionSnapshot(
    String r,
    String s,
    String v,
    ...
)

public static TransactionSnapshot of(Transaction tx) {
    return new TransactionSnapshot(
        tx.getS().toString(16),
        tx.getR().toString(16),

The ordering of S and R appears to be wrong in the of function.

The fix is simple: swap the calls getS() and getR(). Since this is on the capture side, it then needs to be deployed before any effect can be observed. All captured blocks thus far have swapped values for r and s in the json. Could either manually swap them or just recapture them, etc.

Fixed by #946