Consensys/teku

Make `P2PDebugDataDumper` more generic

Closed this issue · 0 comments

StefanBratanov commented

There is value in making P2PDebugDataDumper more generic. Currently, name is slightly misleading, since for example saveInvalidBlockToFile can occur when syncing or when called via the beacon-API, so it is not strictly P2P. We could rename --Xp2p-dumps-to-file-enabled to sth like --Xdebug-data-dumping-enabled and rename P2PDebugDataDumper to DebugDataDumper and use it in several places. Some options are;

  • dump blob sidecars when is_data_available fails
  • dump blobs bundle coming from builder if it fails the consistency checks