fix applyDepositToValidatorIndex

Closed this issue 2 months ago · 0 comments

rolfyone commented 2 months ago

https://github.com/consensys/teku/blob/404bb71c6ed577f6ab192b65a5d89d2c740ad591/ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/versions/electra/block/BlockProcessorElectra.java#L349-L352
Here's the spec:
https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/beacon-chain.md#updated--apply_deposit
The teku version appears to be missing the has_eth1_withdrawal_credential check.
And shouldn't it check the signature if signatureAlreadyVerified is false?
Like signatureAlreadyVerified || depositSignatureIsValid(...)