Corfucinas/crypto-candlesticks

Are these assignments incorrect?

Opened this issue · 1 comments

'Open': candle[2],
'Close': candle[1],

Hi - Just wondering why Open and Close values are assigned as indexes 2 and 1 respectively, and not 1 and 2?

The Bitfinex API docs shows that it should be 1, 2.

Good question, I coded this using old documentation from Bitfinex (they have replaced it) two years ago. There's the possibility that I got it wrong or that they have updated the index with the new API(?). In any case, I'll replace the slices with a Dataclass in the next release, using tuple slices it's bad anyways.

I'll leave this open as a reminder