Corosauce/weather2

[1.20.1] Lightning flashes / bolts compatibility with Bliss Shaders (oculus bug)

Closed this issue · 2 comments

Soooo first of all, thank you so much for updating the mod to the 1.20.1 version, however it seems that the update also changed the way the lightning_bolt works and now the Bliss shader isn't able to detect the entity name again

This is an issue that was addressed before:
#578

Example of the issue:

Minecraft.Forge_.1.20.1.-.Singleplayer.2023-12-22.11-39-06-00.00.28.991-00.00.50.724.mp4

In context, before (on 1.18.2), i was able to find a way to make it work with the bliss shaders by adding the registry name "weather2:lightning_bolt" inside the "entity.properties" of the bliss shaders, especifically in the area where bliss controlled the lightning bolts of the shader, like this:
image

i found this by digging inside the files of the weather mod after reading a comment from corosus saying that he was going to make a "fake" vanilla lightning, in order to adress an issue with charged creepers:
image

The thing is that now, with the 1.20.1 version, for some odd reason this stopped working, and i say odd cuz after spending a whole day looking inside the files of the new weather2 mod, i wasn't able to find another registry name, and the only thing that changed was the way the lightning bolt is made (i think? im not a modder sorry lol), before, the lightning_bolt was created by using the code "ObjectHolder":
image

And now is using the code "RegistryObject":
image

which as far as i understand, they are 2 ways to make it work, however, im not sure if corosus decided to make this change in order to optimize the code or if it was a necessary change for the update

Again, as i said, i couldn't find another registry name that replaced the old "weather2:lightning_bolt" name, so i assume that it is still using the same one cuz the way the RegistryObject works it is supposed to have the MODID + "lightning_bolt" as the registry name (unlesss im wrong)

so please, can anyone tell me whats going on? i mean, maybe this way of making the fake lightning bolt doesn't work as an entity at all and thats why the bliss shader can't detect the name (?) or, the registry name is completly different?.. i just really want to make it work cuz this is one of the best shaders out there with good performance and that makes the Tornadoes look AMAZING U - U

in any case.. another idea that was coming to my mind was that maybe corosus could add an option to enable the vanilla lightning bolts to spawn instead of his fake ones? in other words, an option to disable his fake lighning bolts and call the vanilla ones (?).. i guess that could bring some issues so.. idk.. help please :c

NVM.... cant believe i had the answer already.. i stumbled with this just before i discovered the entity name months ago.. the culprit of this issue is oculus U - U the only version that was working was the 1.5.2 for mc 1.18.2, it seems that later updates kept the bug / issue, until now with mc 1.20.1 .. sorry for the post u - u

That is completely fine, yeah oculus/optifine have tendencies to break everything unfortunately.